Include RBS paths when indexing workspace#609
Merged
Conversation
Member
Author
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
bbb8d49 to
6234d63
Compare
Member
Author
|
Ended up uncovering an issue in the RBS crate ruby/rbs#2859 |
Morriar
reviewed
Mar 2, 2026
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
6234d63 to
9eb0af7
Compare
vinistock
changed the base branch from
graphite-base/609
to
02-23-add_integrity_check_for_owner_relationships
This was referenced Mar 4, 2026
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
9eb0af7 to
b8949ac
Compare
Morriar
approved these changes
Mar 4, 2026
vinistock
force-pushed
the
02-23-add_integrity_check_for_owner_relationships
branch
from
8790ac3 to
6863542
Compare
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
b8949ac to
ec07df2
Compare
alexcrocha
approved these changes
Mar 4, 2026
vinistock
force-pushed
the
02-23-add_integrity_check_for_owner_relationships
branch
from
6863542 to
eb1ad09
Compare
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
ec07df2 to
662132a
Compare
vinistock
force-pushed
the
02-23-add_integrity_check_for_owner_relationships
branch
2 times, most recently
from
710ee51 to
520bf5c
Compare
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
662132a to
e1ccf14
Compare
vinistock
force-pushed
the
02-23-add_integrity_check_for_owner_relationships
branch
from
520bf5c to
e2b9d62
Compare
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
e1ccf14 to
d510f97
Compare
vinistock
changed the base branch from
02-23-add_integrity_check_for_owner_relationships
to
graphite-base/609
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
d510f97 to
97a4624
Compare
vinistock
force-pushed
the
02-26-include_rbs_paths_when_indexing_workspace
branch
from
97a4624 to
a101cbd
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have some RBS indexing, we can automatically include the RBS paths for
coreandstdlibto get the complete data when usingindex_workspace. In the future, we may want to ship with a fully indexed RBS cache, but for now let's just include the paths.One design note: we should not require that
rbsbe on the bundle. Instead of usingGem::Specification.findorGem.find_files(both of which are scoped to the bundle), I just searchedGem.pathmanually for the latestrbsinstallation.